feat: add reward ad show API#20
Merged
Merged
Conversation
|
🤖 Hi @2sem, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
|
🤖 I'm sorry @2sem, but I was unable to process your request. Please see the logs for more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal and success criteria
prepare(rewardUnit:)andshow(rewardUnit:).GoogleMobileAds.RewardedAd?directly from the reward-specific show callback.rewardedAd.adReward.show(unit:)compatibility.User flow
flowchart TD A[App calls prepare rewardUnit] --> B[GADManager loads RewardedAd] B -->|Success| C[Cache rewarded ad] B -->|Failure| F[Completion false] C --> D[App calls show rewardUnit] D --> E[Present rewarded ad] E --> G{User earned reward?} G -->|Yes| H[Callback RewardedAd + rewarded=true] G -->|No| I[Callback rewarded=false] H --> J[Read adReward amount and type] J --> K[Auto reprepare] I --> KWorkstreams and deliverables
show(rewardUnit:...)returningRewardedAd?and improve load failure handling.Dependencies and critical path
RewardedAdAPI.Risks and mitigations
prepare(rewardUnit:isTesting:)calls remain valid because the new parameter has a default.false.RewardedAdand can readadReward.amountandadReward.type.Verification
git diff --check origin/mainpasses.swift build --triple arm64-apple-ios12.0-simulator --sdk "$(xcrun --sdk iphonesimulator --show-sdk-path)"passes.Release checklist
RewardedAd.adRewardreturns the expected amount and type.rewardedis true only after reward is earned.